Skip to content

SCRUM-5829 generate variant summary docs for alleles#1560

Merged
cmpich merged 2 commits intostagefrom
SCRUM-5829
Apr 9, 2026
Merged

SCRUM-5829 generate variant summary docs for alleles#1560
cmpich merged 2 commits intostagefrom
SCRUM-5829

Conversation

@cmpich
Copy link
Copy Markdown
Contributor

@cmpich cmpich commented Apr 9, 2026

No description provided.

@cmpich cmpich requested a review from a team as a code owner April 9, 2026 09:05
@claude
Copy link
Copy Markdown

claude bot commented Apr 9, 2026

Code Review

CI Status: test-compile is failing.

Missing class: AlleleToVariantSummaryConverter (imported from org.alliancegenome.core.variant.converters) does not exist in this repository. The other converters used in this file (AlleleSequenceSummaryConverter, AlleleSearchResultConverter) are defined in agr_java_core/src/main/java/org/alliancegenome/core/variant/converters/, but there is no AlleleToVariantSummaryConverter.java there. This is the likely cause of the compile failure.

If this class is intended to come from an updated external dependency (e.g., a new version of agr_curation_api), make sure that dependency is published and the version is bumped here before merging. If it's meant to live in agr_java_core, it needs to be added in this PR or a prerequisite PR.

Otherwise, the integration pattern is correct:

  • Conversion happens before removeTransportFields() — good, since the converter likely needs those transport-only fields.
  • Indexing follows the same pattern as searchDocs (no CurationView class passed). This is consistent with how VariantSummaryCurationIndexer indexes VariantSummaryDocument (line 74 of that file — also no view).

No other issues found in the diff.

Converts AlleleSummaryDocument objects into VariantSummaryDocument
objects so LTP variants indexed through the allele endpoint also
get variant_summary documents for the allele page variant table.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@cmpich cmpich merged commit 93707e1 into stage Apr 9, 2026
5 checks passed
@cmpich cmpich deleted the SCRUM-5829 branch April 9, 2026 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants